Skip to content

Add Option to add FloatingActionButton to BackdrawScaffold#21

Merged
daadu merged 5 commits into
fluttercommunity:masterfrom
felixwortmann:master
May 27, 2020
Merged

Add Option to add FloatingActionButton to BackdrawScaffold#21
daadu merged 5 commits into
fluttercommunity:masterfrom
felixwortmann:master

Conversation

@felixwortmann

@felixwortmann felixwortmann commented May 22, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@WieFel

WieFel commented May 22, 2020

Copy link
Copy Markdown
Collaborator

Ok for me!
@daadu I don't know whether we should already include the version update and the updated changelog?
I let you handle that...

@daadu

daadu commented May 26, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

@felixwortmann @WieFel version bump and changelog should not be added in PR.

I have resolved merge conflicts.

Here are my thoughts:

  • floatingActionButtonLocation and floatingActionButtonAnimator should also be added
  • appBarBackgroundColor should be part of planned BackdropAppBar widget BackdropAppBar #6 BackdropAppBar #23

@WieFel What do you think?

@WieFel

WieFel commented May 26, 2020

Copy link
Copy Markdown
Collaborator

If we merge #23 before this one then the appBarBackgroundColor property could be removed, as it is already handled by BackdropAppBar.
Therefore I was thinking of implementing the app bar before accepting this pull request ;)

@daadu daadu requested review from WieFel and daadu May 26, 2020 15:44
@daadu

daadu commented May 26, 2020

Copy link
Copy Markdown
Member

@felixwortmann Please do the agreed changes.

@daadu

daadu commented May 26, 2020

Copy link
Copy Markdown
Member

@felixwortmann One more change:

  • refactor backPanelBackgroundColor -> backLayerBackgroundColor to be consistent with nomenclature.

@daadu daadu added the changes requested Changes requested in PRs label May 27, 2020
@daadu daadu added this to the v1.0 milestone May 27, 2020
@daadu

daadu commented May 27, 2020

Copy link
Copy Markdown
Member

@felixwortmann Please confirm if you will be working on the changes.

@felixwortmann

felixwortmann commented May 27, 2020

Copy link
Copy Markdown
Contributor Author

@daadu I will implement the changes later today or this week

added FloatingActionButtonLocation
e737280 
added FloatingActionButtonAnimator
removed appBarBackgroundColor
renamed backPandelBackgroundColor to backLayerBackgroundColor
@felixwortmann

felixwortmann commented May 27, 2020

Copy link
Copy Markdown
Contributor Author

@daadu I think this should be it. Can you take a look please?

daadu
daadu approved these changes May 27, 2020
View reviewed changes
Comment thread lib/backdrop.dart Outdated
@daadu

daadu commented May 27, 2020

Copy link
Copy Markdown
Member

LGTM. @WieFel What do you think?

@WieFel

WieFel commented May 27, 2020

Copy link
Copy Markdown
Collaborator

Approved!

@daadu daadu merged commit 40b778d into fluttercommunity:master May 27, 2020
@daadu

daadu commented May 27, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Congrats @felixwortmann your code have landed to v0.3.1 on pub.dev. Also check yourself in Contributor's Section on README !!

@renovate renovate Bot mentioned this pull request May 1, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daadu daadu daadu approved these changes
@WieFel WieFel Awaiting requested review from WieFel

Assignees

@felixwortmann felixwortmann

Labels

changes requested Changes requested in PRs

Projects

None yet

Milestone

v1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@felixwortmann @WieFel @daadu